Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 )
Change subject: cpu/intel/sandybridge: Add `hyper_threading` option
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29669/4/src/cpu/intel/model_206ax/bootblock....
File src/cpu/intel/model_206ax/bootblock.c:
https://review.coreboot.org/#/c/29669/4/src/cpu/intel/model_206ax/bootblock....
PS4, Line 106: read_option(hyper_threading, 1);
Why not get_option(&ht_requested, "hyper_threading")?
Still a romcc bootblock, afaik.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b73e32ff5af8ea64a47e8aa706e27648aaf0993
Gerrit-Change-Number: 29669
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Tue, 28 May 2019 18:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.com
Gerrit-MessageType: comment