Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62472 )
Change subject: soc/medaitek/mt8186: set pin drive strength to 8mA for NOR ......................................................................
Patch Set 4:
(2 comments)
File src/soc/mediatek/mt8186/spi.c:
https://review.coreboot.org/c/coreboot/+/62472/comment/5088128c_7ebed1b1 PS1, Line 17: #define NOR_PIN_DRIVE_STRENTH GPIO_DRV3
'STRENTH' may be misspelled - perhaps 'STRENGTH'?
Please fix.
https://review.coreboot.org/c/coreboot/+/62472/comment/0edcb7a0_f6556356 PS1, Line 155: if (gpio_set_driving(ptr[i].gpio, NOR_PIN_DRIVE_STRENTH) < 0)
'STRENTH' may be misspelled - perhaps 'STRENGTH'?
Please fix.
-
Rex-BC Chen (Code Review)