Hello HAOUAS Elyes, Julius Werner, Angel Pons, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32228
to review the following change.
Change subject: Docs/kconfig: Update to use CONFIG() ......................................................................
Docs/kconfig: Update to use CONFIG()
Change-Id: Ica7b601d1c9c3bcf39b8b805d48e969f8a944927 Signed-off-by: Nico Huber nico.h@gmx.de --- M Documentation/getting_started/kconfig.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32228/1
diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index 7b436ce..249fd46 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -1132,7 +1132,7 @@ as false, the symbol STILL gets defined in the config.h file (though not in the .config file).
-Use #if IS_ENABLED(CONFIG_*) to be sure (it returns false for undefined symbols +Use #if CONFIG(SYMBOL) to be sure (it returns false for undefined symbols and defined-to-0 symbols alike).
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32228 )
Change subject: Docs/kconfig: Update to use CONFIG() ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32228 )
Change subject: Docs/kconfig: Update to use CONFIG() ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32228/1/Documentation/getting_started/kconfi... File Documentation/getting_started/kconfig.md:
https://review.coreboot.org/#/c/32228/1/Documentation/getting_started/kconfi... PS1, Line 1168: - IS_ENABLED() is ‘false’ for undefined variables and ‘0’ variables. In Linux Update now or after you remove it...
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32228 )
Change subject: Docs/kconfig: Update to use CONFIG() ......................................................................
Docs/kconfig: Update to use CONFIG()
Change-Id: Ica7b601d1c9c3bcf39b8b805d48e969f8a944927 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/32228 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M Documentation/getting_started/kconfig.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index 7b436ce..249fd46 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -1132,7 +1132,7 @@ as false, the symbol STILL gets defined in the config.h file (though not in the .config file).
-Use #if IS_ENABLED(CONFIG_*) to be sure (it returns false for undefined symbols +Use #if CONFIG(SYMBOL) to be sure (it returns false for undefined symbols and defined-to-0 symbols alike).