[S] Change in coreboot[master]: soc/intel/rtd3: Fix S3 on TGL and ADL - coreboot-gerrit

4 Feb 2023


      Attention is currently required from: Sean Rhodes, Matt DeVillier, Angel Pons.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72765 )
Change subject: soc/intel/rtd3: Fix S3 on TGL and ADL
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72765/comment/94704251_e0f2cca5 
PS1, Line 9: S3 does not support D3Cold,
...
where's this documented? I'm not seeing anything in Linux/Windows power state docs to indicate D3col […]
IMHO the power rail of S3 on their board can't support it. D3cold more like the HW support.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72765
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e
Gerrit-Change-Number: 72765
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 04 Feb 2023 00:34:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: comment