Hello Felix Singer, build bot (Jenkins), Shaunak Saha, Patrick Georgi, Furquan Shaikh, Justin TerAvest, Matt DeVillier, Duncan Laurie, Paul Menzel, Patrick Rudolph, Nico Huber, Martin Roth, Tim Wawrzynczak, Shaunak Saha, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49045
to look at the new patch set (#4).
Change subject: acpi,soc/intel/common: add support for Intel Low Power Idle Table ......................................................................
acpi,soc/intel/common: add support for Intel Low Power Idle Table
Add support for the Intel LPIT table to support reading Low Power Idle Residency counters by the OS. On platforms supporting S0ix sleep states there can be two types of residencies:
* CPU package PC10 residency counter (read from MSR via FFH interface) * PCH SLP_S0 assertion residency counter (read via memory mapped interface)
With presence of one or both of these counters in the LPIT table, Linux dynamically adds the corresponding attributes to the cpuidle sysfs interface, that can be used to read the residency timers:
* /sys/devices/system/cpu/cpuidle/low_power_idle_cpu_residency_us * /sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us
The code in src/acpi implements generic LPIT support. Each SoC or platform has to implement `acpi_fill_lpit` to fill the table with platform-specific LPI state entries. This is done in this change for soc/intel/common, while being added as its own compilation unit, so SoCs not yet using common acpi code (like Skylake) can use it, too.
Reference: https://uefi.org/sites/default/files/resources/Intel_ACPI_Low_Power_S0_Idle....
Test: Linux adds the cpuidle sysfs interface; Windows with s0ix_enable=1 boots without crashing with an INTERNAL_POWER_ERROR.
- Windows and Linux tested on google/akemi together with CB:49046 - Linux tested on clevo/cml-u together with CB:49046
Change-Id: I816888e8788e2f04c89f20d6ea1654d2f35cf18e Tested-by: Matt DeVillier matt.devillier@gmail.com Tested-by: Michael Niewöhner foss@mniewoehner.de Signed-off-by: Shaunak Saha shaunak.saha@intel.com Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/acpi/Kconfig M src/acpi/acpi.c M src/include/acpi/acpi.h M src/soc/intel/common/block/acpi/Kconfig M src/soc/intel/common/block/acpi/Makefile.inc M src/soc/intel/common/block/acpi/acpi.c A src/soc/intel/common/block/acpi/lpit.c 7 files changed, 182 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/49045/4