Attention is currently required from: Sridhar Siricilla, Arthur Heymans.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63734 )
Change subject: soc/intel/common: Fix buggy code tries to access DESC region
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
SI_DESC is going to be remain in future platforms as well. So, reference to SI_DESC which get defined in the FMAP should be fine , IMO.
The default generated x86 FMAP does not have this. This means that you always need to manually write an FMAP yourself for this feature. Another point is that this pushes problems to the runtime, because there is no buildtime guarantee that this FMAP section will be there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib144cc0845b7527e5a3032529b0802f961944b87
Gerrit-Change-Number: 63734
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 21 Apr 2022 13:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment