Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29414 )
Change subject: src/soc/intel/braswell: Remove disabled LPE ACPI code
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/29414/5/src/soc/intel/braswell/include/soc/a...
File src/soc/intel/braswell/include/soc/acpi.h:
https://review.coreboot.org/#/c/29414/5/src/soc/intel/braswell/include/soc/a...
PS5, Line 29: unsigned long current,
Doesn’t this fit on the line above?
Not all of this.
For line below 80 chars only 'unsigned long' fits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8acf9ea9e9b0ba9b272e20beb2023b7a4716a73
Gerrit-Change-Number: 29414
Gerrit-PatchSet: 6
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Apr 2019 13:05:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment