Change in coreboot[master]: sb/amd/{agesa,pi}/hudson/acpi: Convert 'audio.asl' to ASL 2.0 syntax
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45863 )
Change subject: sb/amd/{agesa,pi}/hudson/acpi: Convert 'audio.asl' to ASL 2.0 syntax ......................................................................
sb/amd/{agesa,pi}/hudson/acpi: Convert 'audio.asl' to ASL 2.0 syntax
Change-Id: I976b4c2e2aa878d8b591c3e416ffb76d7a699b39 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/audio.asl M src/southbridge/amd/pi/hudson/acpi/audio.asl 2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/45863/1
diff --git a/src/southbridge/amd/agesa/hudson/acpi/audio.asl b/src/southbridge/amd/agesa/hudson/acpi/audio.asl index c85710f..8eb0e6d 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/audio.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/audio.asl @@ -28,11 +28,11 @@
Method (_INI, 0, NotSerialized) { - If (LEqual (OSVR, 0x03)) + If (OSVR == 0x03) { - Store (Zero, NSEN) - Store (One, NSDO) - Store (One, NSDI) + NSEN = 0 + NSDO = 1 + NSDI = 1 } } } /* end AZHD */ diff --git a/src/southbridge/amd/pi/hudson/acpi/audio.asl b/src/southbridge/amd/pi/hudson/acpi/audio.asl index c85710f..8eb0e6d 100644 --- a/src/southbridge/amd/pi/hudson/acpi/audio.asl +++ b/src/southbridge/amd/pi/hudson/acpi/audio.asl @@ -28,11 +28,11 @@
Method (_INI, 0, NotSerialized) { - If (LEqual (OSVR, 0x03)) + If (OSVR == 0x03) { - Store (Zero, NSEN) - Store (One, NSDO) - Store (One, NSDI) + NSEN = 0 + NSDO = 1 + NSDI = 1 } } } /* end AZHD */
Attention is currently required from: HAOUAS Elyes. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45863 )
Change subject: sb/amd/{agesa,pi}/hudson/acpi: Convert 'audio.asl' to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45863 )
Change subject: sb/amd/{agesa,pi}/hudson/acpi: Convert 'audio.asl' to ASL 2.0 syntax ......................................................................
sb/amd/{agesa,pi}/hudson/acpi: Convert 'audio.asl' to ASL 2.0 syntax
Change-Id: I976b4c2e2aa878d8b591c3e416ffb76d7a699b39 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45863 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/amd/agesa/hudson/acpi/audio.asl M src/southbridge/amd/pi/hudson/acpi/audio.asl 2 files changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/acpi/audio.asl b/src/southbridge/amd/agesa/hudson/acpi/audio.asl index c85710f..8eb0e6d 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/audio.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/audio.asl @@ -28,11 +28,11 @@
Method (_INI, 0, NotSerialized) { - If (LEqual (OSVR, 0x03)) + If (OSVR == 0x03) { - Store (Zero, NSEN) - Store (One, NSDO) - Store (One, NSDI) + NSEN = 0 + NSDO = 1 + NSDI = 1 } } } /* end AZHD */ diff --git a/src/southbridge/amd/pi/hudson/acpi/audio.asl b/src/southbridge/amd/pi/hudson/acpi/audio.asl index c85710f..8eb0e6d 100644 --- a/src/southbridge/amd/pi/hudson/acpi/audio.asl +++ b/src/southbridge/amd/pi/hudson/acpi/audio.asl @@ -28,11 +28,11 @@
Method (_INI, 0, NotSerialized) { - If (LEqual (OSVR, 0x03)) + If (OSVR == 0x03) { - Store (Zero, NSEN) - Store (One, NSDO) - Store (One, NSDI) + NSEN = 0 + NSDO = 1 + NSDI = 1 } } } /* end AZHD */
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)