Change in coreboot[master]: ec/google/chromeec: OEM variables support for DPTF - coreboot-gerrit

13 May 2021


      Attention is currently required from: Sumeet R Pawnikar, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54098 )
Change subject: ec/google/chromeec: OEM variables support for DPTF
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/54098/comment/152f0b99_a70bdd35 
PS1, Line 136: acpigen_pop_len();
...
Can you please add a comment regarding which scope you are trying to pop? Also shouldn't this be don […]
Actually I recently noticed there are some new `acpigen_*_end` inline functions... for example, acpigen_write_package_end
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79fbf00521d54e66b6cd7d95b026a76fd3a4394b
Gerrit-Change-Number: 54098
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 13 May 2021 17:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment