[S] Change in coreboot[main]: mb/google/fatcat: Introduce variant-specific barrel jack presence check

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87183?usp=email )

Change subject: mb/google/fatcat: Introduce variant-specific barrel jack presence check
......................................................................

mb/google/fatcat: Introduce variant-specific barrel jack presence check

This commit introduces a weak function
`variant_is_barrel_charger_present()` to allow individual Fatcat
variants to specify if they support power-on via a barrel jack.

The default implementation of this function returns `false`,
reflecting the fact that most Chromebook devices within the Fatcat
family primarily use USB-C for power.

The `baseboard_devtree_update()` function is updated to use this
variant-specific check instead of directly calling
`google_chromeec_is_barrel_charger_present()` and checking the board
model. This allows for more flexibility in handling barrel jack
presence across different Fatcat variants.

This change enables specific variants that do support barrel jack
power to override the weak function and return `true`, allowing the
system to behave accordingly (e.g., skipping power optimization when
booting with a barrel charger).

TEST=Able to build and boot google/fatcat.

Change-Id: I613417be5a59790b8a5e6055957a2f518f4c42df
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87183
Reviewed-by: Wonkyu Kim 
Tested-by: build bot (Jenkins) 
Reviewed-by: Pranava Y N 
Reviewed-by: Dinesh Gehlot 
Reviewed-by: Kapil Porwal 
Reviewed-by: Jayvik Desai 
---
M src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c
M src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
2 files changed, 14 insertions(+), 1 deletion(-)

Approvals:
  Wonkyu Kim: Looks good to me, but someone else must approve
  Pranava Y N: Looks good to me, approved
  build bot (Jenkins): Verified
  Dinesh Gehlot: Looks good to me, approved
  Jayvik Desai: Looks good to me, approved
  Kapil Porwal: Looks good to me, approved

diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c b/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c
index 21f8ccd..69d0d67 100644
--- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c
+++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c
@@ -50,10 +50,22 @@
    },
 };

+/*
+ * Placeholder to check if variant has support for barrel jack for powering
+ * on the device.
+ *
+ * Most of the chromebook device is powering on with USB-C hence, unless overridden
+ * by some variant, assume barrel jack not present.
+ */
+__weak bool variant_is_barrel_charger_present(void)
+{
+	return false;
+}
+
 void baseboard_devtree_update(void)
 {
    /* Don't optimize the power limit if booting with barrel attached */
-	if (CONFIG(BOARD_GOOGLE_MODEL_FATCAT) && google_chromeec_is_barrel_charger_present())
+	if (variant_is_barrel_charger_present())
    	return;

if (!google_chromeec_is_battery_present())
diff --git a/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
index c080dd3..ad26ab8 100644
--- a/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/fatcat/variants/baseboard/include/baseboard/variants.h
@@ -26,6 +26,7 @@
 bool variant_is_half_populated(void);
 void variant_update_soc_memory_init_params(FSPM_UPD *memupd);
 void variant_update_soc_chip_config(struct soc_intel_pantherlake_config *config);
+bool variant_is_barrel_charger_present(void);

enum s0ix_entry {
    S0IX_EXIT,