Attention is currently required from: Shelley Chen, Julius Werner.
Doug Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70230 )
Change subject: mb/google/herobrine: NVMe id determined by logical (not physical) bit ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Patchset:
PS2: Better than it was, but still not quite right. ;-)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70230/comment/71e27e5b_71bfb157 PS2, Line 100: & sku_bits_mask Remove this. You don't need it with the new math below and I think it totally breaks the check for `sku == CROS_SKU_UNKNOWN` and `CROS_SKU_UNPROVISIONED` since both of those have high bits set.