Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )
Change subject: soc/intel/common: Don't hardcode ramtop offset
......................................................................
Patch Set 11: -Code-Review
(1 comment)
Patchset:
PS11:
Just realized there are multiple bit-vs-bytes issues here (probably also before
the patch).
Numbers in the cmos.layout are in bits. AFAICT, the struct is 10 Bytes long.
The `/ 8` was lost between patchsets, but the length looks wrong from the
beginning.
Checking the alignment might not be necessary because nvramtool should handle
that at build time. But please test to make sure in case you want to remove
the check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 11
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 02 May 2023 19:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment