Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39619 )
Change subject: utin/lint/spelling.txt: Disable `afe` ......................................................................
utin/lint/spelling.txt: Disable `afe`
Uppercase `AFE` is an acronym for `Analog Front-End`. As it is a valid spelling, comment out its entry to prevent false positives.
Change-Id: Ib8612d970d33d4955c572838bda217cfdb49dfe6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/lint/spelling.txt 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/39619/1
diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt index 58fe30d..8738077 100644 --- a/util/lint/spelling.txt +++ b/util/lint/spelling.txt @@ -12,6 +12,9 @@ # Reason: Both spellings are correct. #acknowledgement||acknowledgment # +# Reason: AFE means `Analog Front-End`, and appears on register names. +#afe||safe +# # Reason: On RISC-V, `SEPC` is the name of a register. #sepc||spec # @@ -343,7 +346,6 @@ adviced||advised afecting||affecting afer||after -afe||safe affortable||affordable afforts||affords affort||afford
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39619 )
Change subject: utin/lint/spelling.txt: Disable `afe` ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Arthur Heymans, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39619
to look at the new patch set (#3).
Change subject: util/lint/spelling.txt: Disable `afe` ......................................................................
util/lint/spelling.txt: Disable `afe`
Uppercase `AFE` is an acronym for `Analog Front-End`. As it is a valid spelling, comment out its entry to prevent false positives.
Change-Id: Ib8612d970d33d4955c572838bda217cfdb49dfe6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/lint/spelling.txt 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/39619/3
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39619 )
Change subject: util/lint/spelling.txt: Disable `afe` ......................................................................
util/lint/spelling.txt: Disable `afe`
Uppercase `AFE` is an acronym for `Analog Front-End`. As it is a valid spelling, comment out its entry to prevent false positives.
Change-Id: Ib8612d970d33d4955c572838bda217cfdb49dfe6 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39619 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/lint/spelling.txt 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt index 58fe30d..8738077 100644 --- a/util/lint/spelling.txt +++ b/util/lint/spelling.txt @@ -12,6 +12,9 @@ # Reason: Both spellings are correct. #acknowledgement||acknowledgment # +# Reason: AFE means `Analog Front-End`, and appears on register names. +#afe||safe +# # Reason: On RISC-V, `SEPC` is the name of a register. #sepc||spec # @@ -343,7 +346,6 @@ adviced||advised afecting||affecting afer||after -afe||safe affortable||affordable afforts||affords affort||afford
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39619 )
Change subject: util/lint/spelling.txt: Disable `afe` ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1428 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1427 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1426
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)