Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46272 )
Change subject: soc/intel/skl,cpu/intel: copy AES-NI locking to common cpu code ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46272/6/src/cpu/intel/common/common... File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/46272/6/src/cpu/intel/common/common... PS6, Line 280: I would note that CPUID Leaf 0x1, ecx[25] indicates AES-NI support. Should we verify that first ?
https://review.coreboot.org/c/coreboot/+/46272/6/src/cpu/intel/common/common... PS6, Line 282: (msr.lo & 1) == 0) if (!(msr.lo & AESNI_LOCK_BIT))
https://review.coreboot.org/c/coreboot/+/46272/6/src/cpu/intel/common/common... PS6, Line 283: 1 AESNI_LOCK_BIT
https://review.coreboot.org/c/coreboot/+/46272/6/src/include/cpu/intel/msr.h File src/include/cpu/intel/msr.h:
https://review.coreboot.org/c/coreboot/+/46272/6/src/include/cpu/intel/msr.h... PS6, Line 9: 0 BIT(0)