Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Tarun, Tyler Wang, YH Lin.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/karis: Add FAN field in fw_config
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/rex/variants/karis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78216/comment/cf16aaf2_8ad1249e :
PS5, Line 244: probe FAN FAN_SETTING_1
Are you sure? this will turn off the all table if no FAN... If for no fan, you need create new one. Or just override by device tree update or something..
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78216?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b
Gerrit-Change-Number: 78216
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 11 Oct 2023 13:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment