Attention is currently required from: Kane Chen, Kapil Porwal, Kun Liu, Stefan Reinauer.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79902?usp=email )
Change subject: util/ifdtool: Enable Read Access for SPI device expansion 2 region ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Not blocking this CL, but a couple more things:
- flashrom support should be added for this region. flashrom knows how to handle regions it doesn't have read/write access to, so it shouldn't fail in this way even if read access was disabled. Can you file a bug for this if there isn't one already?
Sure, b/319773700
- Do we understand why this region was added? It looks like it's just the unused space between the end of the ME and start of the BIOS. This used to be part of the ME region. Do we know why it was split out into a separate region?
the padding region has added to match the gap between IFWI and BIOS region as per my understanding. If your IFWI/ME itself is big enough to fit into SI_ME allocated region then there won't be any padding region exist.