Attention is currently required from: Felix Held, Maxim.
Fabian Meyer has posted comments on this change by Fabian Meyer. ( https://review.coreboot.org/c/coreboot/+/82204?usp=email )
Change subject: util/intelp2m: Add support for Emmitsburg macro generation ......................................................................
Patch Set 4:
(1 comment)
File util/intelp2m/platforms/ebg/template.go:
https://review.coreboot.org/c/coreboot/+/82204/comment/009bbbb7_8ce793a0?usp... : PS3, Line 17: GPP_S
not sure if there's a difference between GPP and GPPC, but in util/inteltool/gpio_names/emmitsburg. […]
You are correct, it's also GPPC_S in src/soc/intel/xeon_sp/ebg/include/soc/gpio_soc_defs.h. However, this makes no difference to intelp2m's output (I just tested it). I pushed the change nonetheless to be more correct.