Attention is currently required from: Sean Rhodes, Angel Pons, Maximilian Brune, Lean Sheng Tan.
Hello build bot (Jenkins), Benjamin Doron, Maximilian Brune,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74121
to look at the new patch set (#3).
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
[RFC] drivers/option: Add option list in cbtable
@@@@@@@@@@@@@@@@@@@@ @ W A R N I N G @ @@@@@@@@@@@@@@@@@@@@
In Patchset 3, the cbtables CFR tags have been renumbered. Also, there have been changes to the structures: strings are now a record, and new fields got added (option_id). THE CHANGES ARE NOT BACKWARDS COMPATIBLE!
TODO: rewrite commit msg, add proper documentation. Maybe add tests.
Introduce a mechanism so that coreboot can provide a list of options to post-coreboot code. This can be used to let payloads know which options should be displayed in a setup menu, for instance. Although this system was written to be used with edk2, it has been designed with flexibility in mind so that other payloads can also make use of this mechanism.
The data structures follow a hitherto undefined specification, known as CFR. This acronym could mean "coreboot forms representation" or "cursed forms representation"; whether the former or the latter is the intended expansion is left as an exercise for the reviewer.
It should be possible to extend these structures in the future, in case additional functionality is needed.
Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/commonlib/include/commonlib/coreboot_tables.h A src/drivers/option/Kconfig A src/drivers/option/Makefile.inc A src/drivers/option/cfr.c A src/drivers/option/cfr.h 5 files changed, 389 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/74121/3
-
Angel Pons (Code Review)