Attention is currently required from: Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78009?usp=email )
Change subject: mb/google/brox: Create new Brox baseboard ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/brox/variants/brox/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/78009/comment/0c42410e_5021d55c : PS3, Line 11: define T1_OFF_MS 16 : #define T2_OFF_MS 2 :
NIT - alphabetize
Done
File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/78009/comment/5837de9f_b856c23b : PS3, Line 7: MT53E512M32D2NP-046 WT:F 0 (0000)
IMO, it's better to check this file (and others in memory folder) in as empty and then add memory op […]
Done
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78009/comment/5dbc2f29_ee717989 : PS3, Line 1: fw_config
This is one of those files that you want to be careful with. […]
Ok, I emptied the device tree.