Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39575 )
Change subject: util/crossgcc: Temporarily disable GDB build test on server ......................................................................
util/crossgcc: Temporarily disable GDB build test on server
The latest debian builder image doesn't compile GDB correctly. Disable the build test until I can get it working again.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I7852a39ed40a7364d24d0bbf014fd25058491083 --- M util/crossgcc/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39575/1
diff --git a/util/crossgcc/Makefile.inc b/util/crossgcc/Makefile.inc index 108612f..ed8d66e 100644 --- a/util/crossgcc/Makefile.inc +++ b/util/crossgcc/Makefile.inc @@ -79,7 +79,9 @@ # This target controls what the jenkins builder tests jenkins-build-toolchain: BUILDGCC_OPTIONS ?= -y --nocolor jenkins-build-toolchain: - $(MAKE) crosstools clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='$(BUILDGCC_OPTIONS)' + $(MAKE) crossgcc clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='$(BUILDGCC_OPTIONS)' + #TODO: Re-enable gdb build after the builders can build it again. + #$(MAKE) crosstools clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='$(BUILDGCC_OPTIONS)' rm -f .xcompile PATH=$(if $(DEST),$(DEST)/bin,$(top)/util/crossgcc/xgcc/bin):$$PATH; $(MAKE) what-jenkins-does -cat .xcompile
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39575 )
Change subject: util/crossgcc: Temporarily disable GDB build test on server ......................................................................
Patch Set 1: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39575 )
Change subject: util/crossgcc: Temporarily disable GDB build test on server ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39575 )
Change subject: util/crossgcc: Temporarily disable GDB build test on server ......................................................................
util/crossgcc: Temporarily disable GDB build test on server
The latest debian builder image doesn't compile GDB correctly. Disable the build test until I can get it working again.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I7852a39ed40a7364d24d0bbf014fd25058491083 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39575 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/Makefile.inc 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/util/crossgcc/Makefile.inc b/util/crossgcc/Makefile.inc index 108612f..ed8d66e 100644 --- a/util/crossgcc/Makefile.inc +++ b/util/crossgcc/Makefile.inc @@ -79,7 +79,9 @@ # This target controls what the jenkins builder tests jenkins-build-toolchain: BUILDGCC_OPTIONS ?= -y --nocolor jenkins-build-toolchain: - $(MAKE) crosstools clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='$(BUILDGCC_OPTIONS)' + $(MAKE) crossgcc clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='$(BUILDGCC_OPTIONS)' + #TODO: Re-enable gdb build after the builders can build it again. + #$(MAKE) crosstools clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='$(BUILDGCC_OPTIONS)' rm -f .xcompile PATH=$(if $(DEST),$(DEST)/bin,$(top)/util/crossgcc/xgcc/bin):$$PATH; $(MAKE) what-jenkins-does -cat .xcompile
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)