HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45754 )
Change subject: mb/Kconfig: Remove duplicated "Mainboard vendor" ......................................................................
mb/Kconfig: Remove duplicated "Mainboard vendor"
Alos move symbol declaration default entries.
Change-Id: I5dcdf4b0157f67a9704d2cbac881ec27064e2072 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/Kconfig 1 file changed, 10 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45754/1
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index af685db..419194f 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -1,17 +1,7 @@ comment "Important: Run 'make distclean' before switching boards"
-choice - prompt "Mainboard vendor" - default VENDOR_EMULATION - -source "src/mainboard/*/Kconfig.name" - -endchoice - -source "src/mainboard/*/Kconfig" - config MAINBOARD_VENDOR - string "Mainboard vendor name" + string
config BOARD_ROMSIZE_KB_256 bool @@ -40,6 +30,15 @@ config BOARD_ROMSIZE_KB_65536 bool
+choice + prompt "Mainboard vendor" + default VENDOR_EMULATION + +source "src/mainboard/*/Kconfig.name" +endchoice + +source "src/mainboard/*/Kconfig" + # TODO: No help text possible for choice fields? choice prompt "ROM chip size"
Hello Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45754
to look at the new patch set (#2).
Change subject: mb/Kconfig: Remove duplicated "Mainboard vendor" ......................................................................
mb/Kconfig: Remove duplicated "Mainboard vendor"
Also move symbol declaration default entries.
Change-Id: I5dcdf4b0157f67a9704d2cbac881ec27064e2072 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/Kconfig 1 file changed, 10 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45754/2
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45754
to look at the new patch set (#3).
Change subject: mb/Kconfig: Remove duplicated "Mainboard vendor" ......................................................................
mb/Kconfig: Remove duplicated "Mainboard vendor"
Also move symbol declaration default entries.
Change-Id: I5dcdf4b0157f67a9704d2cbac881ec27064e2072 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/Kconfig M src/mainboard/Kconfig M src/mainboard/libretrend/Kconfig 3 files changed, 12 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45754/3
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45754
to look at the new patch set (#4).
Change subject: mb/Kconfig: Remove duplicated "Mainboard vendor" ......................................................................
mb/Kconfig: Remove duplicated "Mainboard vendor"
Also move symbol declaration default entries.
Change-Id: I5dcdf4b0157f67a9704d2cbac881ec27064e2072 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/Kconfig M src/mainboard/Kconfig M src/mainboard/libretrend/Kconfig 3 files changed, 12 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45754/4
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45754
to look at the new patch set (#5).
Change subject: mb/Kconfig: Remove duplicated "Mainboard vendor" ......................................................................
mb/Kconfig: Remove duplicated "Mainboard vendor"
Also move symbol declaration before default entries.
Change-Id: I5dcdf4b0157f67a9704d2cbac881ec27064e2072 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/Kconfig M src/mainboard/Kconfig M src/mainboard/libretrend/Kconfig 3 files changed, 12 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45754/5
-
HAOUAS Elyes (Code Review)