Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Rocky Phagura, Tim Wawrzynczak, David Hendricks, Morgan Jang, Patrick Rudolph, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52090 )
Change subject: src/intel/xeon_sp: add hardware error support (HEST)
......................................................................
Patch Set 18: -Code-Review
(2 comments)
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/52090/comment/057720ab_d5cdb1ba
PS18, Line 27: , 8, // 0x40 - 0x48 Hest log buffer
runtime ASL code does not use it. But runtime SMM uses GNVS to retrieve the hest log address.
Where in SMM is this being used? I can't see it.
File src/soc/intel/xeon_sp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52090/comment/c9b403ed_1218951c
PS18, Line 19: ifeq ($(CONFIG_SOC_INTEL_XEON_RAS),y)
: subdirs-y += ras
: endif
Much simpler:
subdirs-$(CONFIG_SOC_INTEL_XEON_RAS) += ras
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If76b2af153616182cc053ca878f30fe056e9c8bd
Gerrit-Change-Number: 52090
Gerrit-PatchSet: 18
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Rocky Phagura
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 28 May 2021 08:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Rocky Phagura
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment