Attention is currently required from: Sean Rhodes, Nico Huber, Tarun Tuli, Michał Żygowski, Subrata Banik, Paul Menzel, Arthur Heymans.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71715 )
Change subject: soc/intel/alderlake: Hook up PchHdaAudioLinkHdaEnable to devicetree
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I checked the FSP it does change the GPIO NF functions. Please see the HdaSocLib, and coreboot won't let FSP configure gpio override but the comment still correct.
As long as you configure the the gpio correctly in your gpio table, the audio should work. Seem like set this to 1 is do nothing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f27f41a4a4b3844a65d45d36aba37c3af1050a0
Gerrit-Change-Number: 71715
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 16 Jan 2023 01:29:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment