New patch to review for coreboot: 86dc127 superio/winbond/w83627ehg: EOL some model specific sio func

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5870

-gerrit

commit 86dc127007a15639e76bfa27211d71a90a29c899
Author: Edward O'Callaghan 
Date:   Mon May 26 04:03:24 2014 +1000

superio/winbond/w83627ehg: EOL some model specific sio func

These are actually not necessary, and badly written API's, if Super I/O
    support is properly utilized.

Change-Id: I39b621e582f8d0762276d29492c91dce500f0665
    Signed-off-by: Edward O'Callaghan 
---
 src/mainboard/nvidia/l1_2pvv/romstage.c    |  3 ++-
 src/superio/winbond/w83627ehg/Makefile.inc |  1 -
 src/superio/winbond/w83627ehg/early_init.c | 38 ------------------------------
 src/superio/winbond/w83627ehg/w83627ehg.h  |  5 ----
 4 files changed, 2 insertions(+), 45 deletions(-)

diff --git a/src/mainboard/nvidia/l1_2pvv/romstage.c b/src/mainboard/nvidia/l1_2pvv/romstage.c
index d411354..7a136d0 100644
--- a/src/mainboard/nvidia/l1_2pvv/romstage.c
+++ b/src/mainboard/nvidia/l1_2pvv/romstage.c
@@ -36,6 +36,7 @@
 #include "lib/delay.c"
 #include "cpu/x86/lapic.h"
 #include "northbridge/amd/amdk8/reset_test.c"
+#include <superio/winbond/common/winbond.h>
 #include <superio/winbond/w83627ehg/w83627ehg.h>
 #include "cpu/x86/bist.h"
 #include "northbridge/amd/amdk8/debug.c"
@@ -119,11 +120,11 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)

pnp_enter_ext_func_mode(SERIAL_DEV);
    pnp_write_config(SERIAL_DEV, 0x24, 0);
- 	w83627ehg_enable_dev(SERIAL_DEV, CONFIG_TTYS0_BASE);
    pnp_exit_ext_func_mode(SERIAL_DEV);

setup_mb_resource_map();

+	winbond_enable_dev(SERIAL_DEV, CONFIG_TTYS0_BASE);
    console_init();

/* Halt if there was a built in self test failure */
diff --git a/src/superio/winbond/w83627ehg/Makefile.inc b/src/superio/winbond/w83627ehg/Makefile.inc
index 19f069f..6914411 100644
--- a/src/superio/winbond/w83627ehg/Makefile.inc
+++ b/src/superio/winbond/w83627ehg/Makefile.inc
@@ -19,6 +19,5 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 ##

-romstage-$(CONFIG_SUPERIO_WINBOND_W83627EHG) += early_init.c
 romstage-$(CONFIG_SUPERIO_WINBOND_W83627EHG) += early_serial.c
 ramstage-$(CONFIG_SUPERIO_WINBOND_W83627EHG) += superio.c
diff --git a/src/superio/winbond/w83627ehg/early_init.c b/src/superio/winbond/w83627ehg/early_init.c
deleted file mode 100644
index d767aa0..0000000
--- a/src/superio/winbond/w83627ehg/early_init.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007 AMD
- * Written by Yinghai Lu  for AMD.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-#include <arch/io.h>
-#include <device/pnp.h>
-#include "w83627ehg.h"
-
-void w83627ehg_disable_dev(device_t dev)
-{
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-}
-
-void w83627ehg_enable_dev(device_t dev, u16 iobase)
-{
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
-	pnp_set_enable(dev, 1);
-}
diff --git a/src/superio/winbond/w83627ehg/w83627ehg.h b/src/superio/winbond/w83627ehg/w83627ehg.h
index 02041fc..221de7b 100644
--- a/src/superio/winbond/w83627ehg/w83627ehg.h
+++ b/src/superio/winbond/w83627ehg/w83627ehg.h
@@ -54,11 +54,6 @@
 #define W83627EHG_GPIO4	((2 << 8) | W83627EHG_GPIO_SUSLED_V)
 #define W83627EHG_GPIO5	((3 << 8) | W83627EHG_GPIO_SUSLED_V)

-#if defined(__PRE_RAM__)
-void w83627ehg_enable_dev(device_t dev, u16 iobase);
-void w83627ehg_disable_dev(device_t dev);
-#endif
-
 void pnp_enter_ext_func_mode(device_t dev);
 void pnp_exit_ext_func_mode(device_t dev);