Attention is currently required from: Maulik V Vaghela, Sridhar Siricilla. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62272 )
Change subject: soc/intel/adl: Send EOP early in the boot sequence ......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/62272/comment/3e03a4c4_b3cef56d PS6, Line 158: early I would avoid saying `early` here, sending a cmd post FSP-S is not actually "early" IMO, hence, I would rather say the fact about Intel CSE team recommended to send EOP cmd within a window between post FSP-S and current EOP boot state (BS_PAYLOAD_BOOT/BS_PAYLOAD_LOAD) to record the minimum time penalty with EOP command.
https://review.coreboot.org/c/coreboot/+/62272/comment/44a44839_1a6c4a2e PS6, Line 161: did u miss SOC_INTEL_CSE_SEND_EOP_EARLY check here ?
-
Subrata Banik (Code Review)