Hello Kyösti Mälkki, ron minnich, Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37577
to review the following change.
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Kconfig: Drop NO_RELOCATABLE_RAMSTAGE
It's not selected anywhere anymore. Drop it and set the default for RELOCATABLE_RAMSTAGE directly.
Change-Id: I580e89525ece39418afeefd6a9d0b89b370ca95f Signed-off-by: Nico Huber nico.h@gmx.de --- M src/Kconfig 1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37577/1
diff --git a/src/Kconfig b/src/Kconfig index 2e06299..25bb450 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -263,14 +263,9 @@ say N because it adds a small performance penalty and may abort on code that happens to work in spite of the UB.
-config NO_RELOCATABLE_RAMSTAGE - bool - default n if ARCH_X86 - default y - config RELOCATABLE_RAMSTAGE bool - default !NO_RELOCATABLE_RAMSTAGE + default y if ARCH_X86 select RELOCATABLE_MODULES help The reloctable ramstage support allows for the ramstage to be built
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37577 )
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37577/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/37577/1/src/Kconfig@269 PS1, Line 269: select OT: 'depends on' would make more sense IMO.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37577 )
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37577/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/37577/1/src/Kconfig@269 PS1, Line 269: select
OT: 'depends on' would make more sense IMO.
Done
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37577 )
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1: Code-Review+2
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37577 )
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37577 )
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Kconfig: Drop NO_RELOCATABLE_RAMSTAGE
It's not selected anywhere anymore. Drop it and set the default for RELOCATABLE_RAMSTAGE directly.
Change-Id: I580e89525ece39418afeefd6a9d0b89b370ca95f Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/37577 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: ron minnich rminnich@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/Kconfig 1 file changed, 1 insertion(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved ron minnich: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 2e06299..25bb450 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -263,14 +263,9 @@ say N because it adds a small performance penalty and may abort on code that happens to work in spite of the UB.
-config NO_RELOCATABLE_RAMSTAGE - bool - default n if ARCH_X86 - default y - config RELOCATABLE_RAMSTAGE bool - default !NO_RELOCATABLE_RAMSTAGE + default y if ARCH_X86 select RELOCATABLE_MODULES help The reloctable ramstage support allows for the ramstage to be built
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37577 )
Change subject: Kconfig: Drop NO_RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 2: Code-Review+2
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
ron minnich (Code Review)