Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32273
Change subject: drivers/i2c/sx9310: Add support for GPIO IRQ ......................................................................
drivers/i2c/sx9310: Add support for GPIO IRQ
This change adds support for mainboards to use GPIO IRQ instead of IOAPIC to accomodate for cases where IOAPIC routing might not be available for certain pads.
BUG=b:129794308
Change-Id: I3e2bb4280303cea177cc0c803d29140731e2b44a Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/i2c/sx9310/chip.h M src/drivers/i2c/sx9310/sx9310.c 2 files changed, 20 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/32273/1
diff --git a/src/drivers/i2c/sx9310/chip.h b/src/drivers/i2c/sx9310/chip.h index 2799f5b..c99a8a1 100644 --- a/src/drivers/i2c/sx9310/chip.h +++ b/src/drivers/i2c/sx9310/chip.h @@ -22,10 +22,20 @@ #define REGISTER(NAME) uint8_t NAME
struct drivers_i2c_sx9310_config { - const char *desc; /* Device Description */ - unsigned int uid; /* ACPI _UID */ - enum i2c_speed speed; /* Bus speed in Hz, default is I2C_SPEED_FAST */ - struct acpi_irq irq; /* Interrupt */ + /* Device Description */ + const char *desc; + + /* ACPI _UID */ + unsigned int uid; + + /* Bus speed in Hz, default is I2C_SPEED_FAST */ + enum i2c_speed speed; + + /* Use GPIO-based interrupt instead of IO-APIC */ + struct acpi_gpio irq_gpio; + + /* IO-APIC interrupt */ + struct acpi_irq irq; #include "registers.h" };
diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index afd9e35..aafd7c7 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -59,7 +59,12 @@ acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); acpi_device_write_i2c(&i2c); - acpi_device_write_interrupt(&config->irq); + + if (config->irq_gpio.pin_count) + acpi_device_write_gpio(&config->irq_gpio); + else + acpi_device_write_interrupt(&config->irq); + acpigen_write_resourcetemplate_footer();
/* DSD */
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32273 )
Change subject: drivers/i2c/sx9310: Add support for GPIO IRQ ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32273 )
Change subject: drivers/i2c/sx9310: Add support for GPIO IRQ ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32273 )
Change subject: drivers/i2c/sx9310: Add support for GPIO IRQ ......................................................................
drivers/i2c/sx9310: Add support for GPIO IRQ
This change adds support for mainboards to use GPIO IRQ instead of IOAPIC to accomodate for cases where IOAPIC routing might not be available for certain pads.
BUG=b:129794308
Change-Id: I3e2bb4280303cea177cc0c803d29140731e2b44a Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32273 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/i2c/sx9310/chip.h M src/drivers/i2c/sx9310/sx9310.c 2 files changed, 20 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Aaron Durbin: Looks good to me, approved
diff --git a/src/drivers/i2c/sx9310/chip.h b/src/drivers/i2c/sx9310/chip.h index 2799f5b..c99a8a1 100644 --- a/src/drivers/i2c/sx9310/chip.h +++ b/src/drivers/i2c/sx9310/chip.h @@ -22,10 +22,20 @@ #define REGISTER(NAME) uint8_t NAME
struct drivers_i2c_sx9310_config { - const char *desc; /* Device Description */ - unsigned int uid; /* ACPI _UID */ - enum i2c_speed speed; /* Bus speed in Hz, default is I2C_SPEED_FAST */ - struct acpi_irq irq; /* Interrupt */ + /* Device Description */ + const char *desc; + + /* ACPI _UID */ + unsigned int uid; + + /* Bus speed in Hz, default is I2C_SPEED_FAST */ + enum i2c_speed speed; + + /* Use GPIO-based interrupt instead of IO-APIC */ + struct acpi_gpio irq_gpio; + + /* IO-APIC interrupt */ + struct acpi_irq irq; #include "registers.h" };
diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index afd9e35..aafd7c7 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -59,7 +59,12 @@ acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); acpi_device_write_i2c(&i2c); - acpi_device_write_interrupt(&config->irq); + + if (config->irq_gpio.pin_count) + acpi_device_write_gpio(&config->irq_gpio); + else + acpi_device_write_interrupt(&config->irq); + acpigen_write_resourcetemplate_footer();
/* DSD */
-
Aaron Durbin (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)