Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31670
Change subject: mb/google/sarien: Enable MAC address passthru support ......................................................................
mb/google/sarien: Enable MAC address passthru support
Enable the support for proving a MAC address for a dock to use based on the VPD values set in the platform.
BUG=b:123925776 TEST=tested on sarien by setting VPD values and observing the string returned by the AMAC() method:
vpd -i RO_VPD -s "ethernet_mac0"="AA:AA:AA:AA:AA:AA" vpd -i RO_VPD -s "dock_mac"="BB:BB:BB:BB:BB:BB"
1) Test with no policy set, returns "dock_mac" ACPI Debug: "VPD region RW did not verify" ACPI Debug: "Found VPD KEY dock_mac = BB:BB:BB:BB:BB:BB" ACPI Debug: "MAC address returned from VPD: BB:BB:BB:BB:BB:BB" ACPI Debug: "AMAC = _AUXMAC_#BBBBBBBBBBBB#"
2) Test with policy set to "builtin", returns nothing
vpd -i RW_VPD -s "dock_passthru"="builtin"
ACPI Debug: "Found VPD KEY dock_passthru = builtin" [AMAC returns Zero]
3) Test with policy set to "ethernet_mac0"
vpd -i RW_VPD -s "dock_passthru"="ethernet_mac0"
ACPI Debug: "Found VPD KEY dock_passthru = ethernet_mac0" ACPI Debug: "Found VPD KEY ethernet_mac0 = AA:AA:AA:AA:AA:AA" ACPI Debug: "MAC address returned from VPD: AA:AA:AA:AA:AA:AA" ACPI Debug: "AMAC = _AUXMAC_#AAAAAAAAAAAA#"
4) Test with policy set to "dock_mac"
vpd -i RW_VPD -s "dock_passthru"="dock_mac"
ACPI Debug: "Found VPD KEY dock_passthru = dock_mac" ACPI Debug: "Found VPD KEY dock_mac = BB:BB:BB:BB:BB:BB" ACPI Debug: "MAC address returned from VPD: BB:BB:BB:BB:BB:BB" ACPI Debug: "AMAC = _AUXMAC_#BBBBBBBBBBBB#"
Change-Id: I90474e264cc433c0fd1a4b0dbaf98e5f74180d54 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/sarien/dsdt.asl 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/31670/1
diff --git a/src/mainboard/google/sarien/dsdt.asl b/src/mainboard/google/sarien/dsdt.asl index 547253f..642e240 100644 --- a/src/mainboard/google/sarien/dsdt.asl +++ b/src/mainboard/google/sarien/dsdt.asl @@ -45,6 +45,10 @@ #if IS_ENABLED(CONFIG_CHROMEOS) /* Chrome OS specific */ #include <vendorcode/google/chromeos/acpi/chromeos.asl> + /* VPD support */ + #include <vendorcode/google/chromeos/acpi/vpd.asl> + /* MAC address passthru */ + #include <vendorcode/google/chromeos/acpi/amac.asl> #endif
/* Chipset specific sleep states */
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31670 )
Change subject: mb/google/sarien: Enable MAC address passthru support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31670/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31670/1//COMMIT_MSG@9 PS1, Line 9: proving providing
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31670
to look at the new patch set (#2).
Change subject: mb/google/sarien: Enable MAC address passthru support ......................................................................
mb/google/sarien: Enable MAC address passthru support
Enable the support for providing a MAC address for a dock to use based on the VPD values set in the platform.
BUG=b:123925776 TEST=tested on sarien by setting VPD values and observing the string returned by the AMAC() method:
vpd -i RO_VPD -s "ethernet_mac0"="AA:AA:AA:AA:AA:AA" vpd -i RO_VPD -s "dock_mac"="BB:BB:BB:BB:BB:BB"
1) Test with no policy set, returns "dock_mac" ACPI Debug: "VPD region RW did not verify" ACPI Debug: "Found VPD KEY dock_mac = BB:BB:BB:BB:BB:BB" ACPI Debug: "MAC address returned from VPD: BB:BB:BB:BB:BB:BB" ACPI Debug: "AMAC = _AUXMAC_#BBBBBBBBBBBB#"
2) Test with policy set to "builtin", returns nothing
vpd -i RW_VPD -s "dock_passthru"="builtin"
ACPI Debug: "Found VPD KEY dock_passthru = builtin" [AMAC returns Zero]
3) Test with policy set to "ethernet_mac0"
vpd -i RW_VPD -s "dock_passthru"="ethernet_mac0"
ACPI Debug: "Found VPD KEY dock_passthru = ethernet_mac0" ACPI Debug: "Found VPD KEY ethernet_mac0 = AA:AA:AA:AA:AA:AA" ACPI Debug: "MAC address returned from VPD: AA:AA:AA:AA:AA:AA" ACPI Debug: "AMAC = _AUXMAC_#AAAAAAAAAAAA#"
4) Test with policy set to "dock_mac"
vpd -i RW_VPD -s "dock_passthru"="dock_mac"
ACPI Debug: "Found VPD KEY dock_passthru = dock_mac" ACPI Debug: "Found VPD KEY dock_mac = BB:BB:BB:BB:BB:BB" ACPI Debug: "MAC address returned from VPD: BB:BB:BB:BB:BB:BB" ACPI Debug: "AMAC = _AUXMAC_#BBBBBBBBBBBB#"
Change-Id: I90474e264cc433c0fd1a4b0dbaf98e5f74180d54 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/sarien/dsdt.asl 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/31670/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31670 )
Change subject: mb/google/sarien: Enable MAC address passthru support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31670/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31670/1//COMMIT_MSG@9 PS1, Line 9: proving
providing
Done
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31670 )
Change subject: mb/google/sarien: Enable MAC address passthru support ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31670 )
Change subject: mb/google/sarien: Enable MAC address passthru support ......................................................................
mb/google/sarien: Enable MAC address passthru support
Enable the support for providing a MAC address for a dock to use based on the VPD values set in the platform.
BUG=b:123925776 TEST=tested on sarien by setting VPD values and observing the string returned by the AMAC() method:
vpd -i RO_VPD -s "ethernet_mac0"="AA:AA:AA:AA:AA:AA" vpd -i RO_VPD -s "dock_mac"="BB:BB:BB:BB:BB:BB"
1) Test with no policy set, returns "dock_mac" ACPI Debug: "VPD region RW did not verify" ACPI Debug: "Found VPD KEY dock_mac = BB:BB:BB:BB:BB:BB" ACPI Debug: "MAC address returned from VPD: BB:BB:BB:BB:BB:BB" ACPI Debug: "AMAC = _AUXMAC_#BBBBBBBBBBBB#"
2) Test with policy set to "builtin", returns nothing
vpd -i RW_VPD -s "dock_passthru"="builtin"
ACPI Debug: "Found VPD KEY dock_passthru = builtin" [AMAC returns Zero]
3) Test with policy set to "ethernet_mac0"
vpd -i RW_VPD -s "dock_passthru"="ethernet_mac0"
ACPI Debug: "Found VPD KEY dock_passthru = ethernet_mac0" ACPI Debug: "Found VPD KEY ethernet_mac0 = AA:AA:AA:AA:AA:AA" ACPI Debug: "MAC address returned from VPD: AA:AA:AA:AA:AA:AA" ACPI Debug: "AMAC = _AUXMAC_#AAAAAAAAAAAA#"
4) Test with policy set to "dock_mac"
vpd -i RW_VPD -s "dock_passthru"="dock_mac"
ACPI Debug: "Found VPD KEY dock_passthru = dock_mac" ACPI Debug: "Found VPD KEY dock_mac = BB:BB:BB:BB:BB:BB" ACPI Debug: "MAC address returned from VPD: BB:BB:BB:BB:BB:BB" ACPI Debug: "AMAC = _AUXMAC_#BBBBBBBBBBBB#"
Change-Id: I90474e264cc433c0fd1a4b0dbaf98e5f74180d54 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/31670 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/google/sarien/dsdt.asl 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/dsdt.asl b/src/mainboard/google/sarien/dsdt.asl index 547253f..642e240 100644 --- a/src/mainboard/google/sarien/dsdt.asl +++ b/src/mainboard/google/sarien/dsdt.asl @@ -45,6 +45,10 @@ #if IS_ENABLED(CONFIG_CHROMEOS) /* Chrome OS specific */ #include <vendorcode/google/chromeos/acpi/chromeos.asl> + /* VPD support */ + #include <vendorcode/google/chromeos/acpi/vpd.asl> + /* MAC address passthru */ + #include <vendorcode/google/chromeos/acpi/amac.asl> #endif
/* Chipset specific sleep states */
-
Duncan Laurie (Code Review) -
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)