Change in coreboot[master]: ec/starlabs/merlin: Apply EC settings when suspending - coreboot-gerrit

2 Jan 2022


      Attention is currently required from: Sean Rhodes, Andy Pont.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60165 )
Change subject: ec/starlabs/merlin: Apply EC settings when suspending
......................................................................
Patch Set 12:
(1 comment)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/60165/comment/ced10b26_2204ca32 
PS12, Line 10: 		_SB.PCI0.LPCB.TPLC = _SB.PCI0.LPCB.EC.TPLE
Can you please elaborate in the commit message, why the assignment was switched? So before, the values out of CMOS were stored in the EC?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf
Gerrit-Change-Number: 60165
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes admin@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes admin@starlabs.systems
Gerrit-Attention: Andy Pont andy.pont@sdcsystems.com
Gerrit-Comment-Date: Sun, 02 Jan 2022 20:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment