[XL] Change in coreboot[master]: ec/google/chromeec: clang-format ec_commands.h - coreboot-gerrit

5 Feb 2023


      Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72639 )
Change subject: ec/google/chromeec: clang-format ec_commands.h
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/72639/comment/2fa79e85_dad7d4b7 
PS1, Line 96: #define EC_LPC_ADDR_HOST_PARAM
consider moving the comment to a single line above this to prevent the weird wrapping:
/* For version 2 params; size is EC_PROTO2_MAX_PARAM_SIZE */
 #define EC_LPC_ADDR_HOST_PARAM   0x804
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06
Gerrit-Change-Number: 72639
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Boris Mittelberg bmbm@google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Boris Mittelberg bmbm@google.com
Gerrit-Comment-Date: Sun, 05 Feb 2023 17:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment