Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47246 )
Change subject: soc/intel/common/acpi: drop the southridge scope around PEPD
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47246/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47246/2//COMMIT_MSG@9
PS2, Line 9: PEPD will get included directly in the southbridge.
IMO that's not an argument. […]
I agree with Michael. Also, other devices in this directory also don't
specify their exact scope (and I think for this PEPD, it matters even
less, probably just needs to be somewhere below _SB).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb7a40e476966a7aca36bee055ee71d181508b87
Gerrit-Change-Number: 47246
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 22:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment