Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28648 )
Change subject: nb/intel/i945: Set CxDRT1 tRPALL bit if populated with 8-bank
......................................................................
Patch Set 14:
BIOS programs this register with “least common denominator” values after reading the SPD
registers of each DIMM in the channel."
So looks like it's the least common denominator *per channel*
and not for all DIMMs in the system.
I guess the code is full of such issues anyway (i.e. expects equal
DIMMs in the channels) but we shouldn't make this worse if we can
avoid it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6c7dccd295e187acfe00a08294010af53b4d0ee
Gerrit-Change-Number: 28648
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Nov 2019 14:16:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment