Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30335 )
Change subject: superio/ite: Add IT8786E-I ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30335/6/src/superio/ite/it8786e/superio.c File src/superio/ite/it8786e/superio.c:
https://review.coreboot.org/#/c/30335/6/src/superio/ite/it8786e/superio.c@62 PS6, Line 62: &ops these should be all NULL, since no LDN-specific override is needed here. &ops needs to be passed to pnp_enable_devices though; see below
https://review.coreboot.org/#/c/30335/6/src/superio/ite/it8786e/superio.c@11... PS6, Line 112: &pnp_ops this needs to be &ops