Change in coreboot[master]: mb/google/brask/variants/moli: set up gpio - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: Zoey Wu, Raihow Shi, Felix Held.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62314 )
Change subject: mb/google/brask/variants/moli: set up gpio
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/moli/gpio.c:
https://review.coreboot.org/c/coreboot/+/62314/comment/eb48c98f_d593810d 
PS10, Line 10: 	/* A9  : ESPI_CLK ==> ESPI_CLK */
             : 	PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1),
             : 	/* A10 : ESPI_RESET# ==> ESPI_PCH_RST_EC_L */
             : 	PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1),
I would suggest to remove these two lines and leave it as the default value.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ec41cb843419c32337b66f3877eda5d730cea35
Gerrit-Change-Number: 62314
Gerrit-PatchSet: 10
Gerrit-Owner: Raihow Shi raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Peter Chi peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Zoey Wu zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Raihow Shi raihow_shi@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Mar 2022 02:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment