Attention is currently required from: Nico Huber, Paul Menzel, Julius Werner.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55075 )
Change subject: include: always unsigned long for size_t
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
size_t and ptrdiff_t are part of the language (there are operators that return […]
GCC provides types for all of the other fixed-width integers as well (it even provides its own version of <stdint.h> in freestanding mode), but one disadvantage of that is we loose control of the underlying integer types, and so will probably have to start using PRIuPTR and friends everywhere (bleh). Since those are just library types IMHO I think it's fine if we keep using our own typedefs, but ptrdiff_t should probably be fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a8fa97c6961991dd8e291d2dc7d8762f83cad6d
Gerrit-Change-Number: 55075
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 07 Jun 2021 01:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment