[S] Change in coreboot[main]: soc/intel/common/block/fast_spi: probe for 2nd flash component

[Nico Huber (Code Review)]

Attention is currently required from: Maciej Pijanowski, Paul Menzel.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80608?usp=email )

Change subject: soc/intel/common/block/fast_spi: probe for 2nd flash component
......................................................................

Patch Set 6: Code-Review+2

(3 comments)

Patchset:

PS4:
> Thanks for the review, please let me know if you expect some action from me here.

It's fine, otherwise I would have marked this as unresolved.

File src/soc/intel/common/block/fast_spi/fast_spi_def.h:

https://review.coreboot.org/c/coreboot/+/80608/comment/d65f6b17_3b22281d :
PS4, Line 156: #define SPIBAR_PTINX_IDX_MASK		0xffc
> Because it is not used anymore. The function used to be limited to reading SPDF parameter. […]

Ah, I missed that you removed the last usage. I thought it's kind of documenting
that the other bits are the index and that it's aligned to 4. But I don't mind
dropping it.

File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

https://review.coreboot.org/c/coreboot/+/80608/comment/0cfb2bf4_0be07125 :
PS4, Line 308:  * SFDP table. FLCOMP.C0DEN is no longer used by the Flash Controller.
> I cannot possibly comment on this code as a whole

I doubt we'll find a reviewer who can. And we've waited long enough I guess.