Attention is currently required from: Karthik Ramasubramanian, Naveen M, Pranava Y N, Varun Upadhyay.
Subrata Banik has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85282?usp=email )
Change subject: drivers/soundwire/alc711: Common Kconfig for ALC7xx soundwire codecs
......................................................................
Patch Set 5:
(2 comments)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85282/comment/b1668c5a_f9c15655?usp... :
PS5, Line 107:
don't need tab
https://review.coreboot.org/c/coreboot/+/85282/comment/794bfb65_d18ef3fa?usp... :
PS5, Line 116: config->alc711_address[dev->path.generic.id].link_id = dev->path.generic.id;
: config->alc711_address[dev->path.generic.id].unique_id = dev->path.generic.subid;
shouldn't this be outside #if/#else case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5953d0fcb7b15368888901f88c5616757ac42877
Gerrit-Change-Number: 85282
Gerrit-PatchSet: 5
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Naveen M
naveen.m@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 14:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No