Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31292
Change subject: nb/intel/sandybridge: Use pcidev_on_root() ......................................................................
nb/intel/sandybridge: Use pcidev_on_root()
Change-Id: I959dfd1c10bc1ab85c6392e0090b022934468770 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/intel/sandybridge/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/31292/1
diff --git a/src/northbridge/intel/sandybridge/acpi.c b/src/northbridge/intel/sandybridge/acpi.c index 48be666..c274318 100644 --- a/src/northbridge/intel/sandybridge/acpi.c +++ b/src/northbridge/intel/sandybridge/acpi.c @@ -71,7 +71,7 @@ { const u32 base_mask = ~(u32)(MiB - 1);
- struct device *const host = dev_find_slot(0, PCI_DEVFN(0, 0)); + struct device *const host = pcidev_on_root(0, 0); if (!host) return 0;
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31292 )
Change subject: nb/intel/sandybridge: Use pcidev_on_root() ......................................................................
Patch Set 1: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31292 )
Change subject: nb/intel/sandybridge: Use pcidev_on_root() ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31292 )
Change subject: nb/intel/sandybridge: Use pcidev_on_root() ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31292 )
Change subject: nb/intel/sandybridge: Use pcidev_on_root() ......................................................................
nb/intel/sandybridge: Use pcidev_on_root()
Change-Id: I959dfd1c10bc1ab85c6392e0090b022934468770 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/31292 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/acpi.c b/src/northbridge/intel/sandybridge/acpi.c index 48be666..c274318 100644 --- a/src/northbridge/intel/sandybridge/acpi.c +++ b/src/northbridge/intel/sandybridge/acpi.c @@ -71,7 +71,7 @@ { const u32 base_mask = ~(u32)(MiB - 1);
- struct device *const host = dev_find_slot(0, PCI_DEVFN(0, 0)); + struct device *const host = pcidev_on_root(0, 0); if (!host) return 0;
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Felix Held (Code Review)
-
Kyösti Mälkki (Code Review)