Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55794 )
Change subject: util/cbfstool: Check the provided base address ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: I'm really confused about this whole patch... you already have a region_addr_t, so how could it not be in the region? Converting from a region address for region X into an absolute address and then checking if that address falls in region X feels tautological. Shouldn't the only possible issue there be that the region address is larger than the region size? If so, I think just checking for that explicitly would make this a lot easier to understand.
-
Julius Werner (Code Review)