Change in coreboot[master]: Revert "mb/google/dedede: Add mainboard acpi support for GPIO PM conf...
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46652 )
Change subject: Revert "mb/google/dedede: Add mainboard acpi support for GPIO PM configuration" ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46652/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46652/2/src/mainboard/google/dedede... PS2, Line 42: <soc/intel/common/acpi/lpit.asl>
From what I can tell no. We already don't expose an LPIT table, so that's moot. […]
Regarding notifications, looking at the LPIT table
Display On/Off Notifications are no-op.
S0IX Entry/Exit Notifications notify: 1) EC - Only Wilco EC has registered for S0IX notifications. I don't see ChromeEC registering an hooks. 2) Mainboard - Mainboard hooks are removed in this CL. 3) GPIO PM - GPIO PM hooks are registered only for cannonlake and alderlake.
-
Karthik Ramasubramanian (Code Review)