Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1004133, Al Hirani, Avinash Alevoor, Rob Barnes, Fred Reitberger, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61462 )
Change subject: soc/amd/common/block/psp: add PSP command
......................................................................
Patch Set 11:
(3 comments)
File src/soc/amd/common/block/psp/psp_gen2.c:
https://review.coreboot.org/c/coreboot/+/61462/comment/cd7d82a8_02a01ec3
PS8, Line 125: u32 soc_read_c2p38(void)
since all bit combinations might be valid here, the return value can't be used for both success/erro […]
Done
https://review.coreboot.org/c/coreboot/+/61462/comment/2ef441b9_604d9c65
PS8, Line 147: if (soc_read_c2p38() & CORE_2_PSP_MSG_38_FUSE_SPL) {
this condition is also true in the error case of the soc_read_c2p38 call
Done
https://review.coreboot.org/c/coreboot/+/61462/comment/f33f05cd_92430daf
PS8, Line 152: printk(BIOS_DEBUG, "PSP: Fuse SPL not requested\n");
this needs to be put in curly brackets, since the code in the corresponding if statement is in curly […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0575356a7c6172e2e0f2eaf9d1a6706468fe92d
Gerrit-Change-Number: 61462
Gerrit-PatchSet: 11
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mohan Viswanathan
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Name of user not set #1004133
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Name of user not set #1004133
Gerrit-Attention: Al Hirani
al.hirani13@gmail.com
Gerrit-Attention: Avinash Alevoor
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Feb 2022 20:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment