HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31761
Change subject: mb/siemens/{mc_apl1,mc_tcu3}: Fix typo on "Display" ......................................................................
mb/siemens/{mc_apl1,mc_tcu3}: Fix typo on "Display"
Change-Id: I58ecd95a8427eba87611dd8ea4616aedbb1d01c9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h M src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h M src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h M src/mainboard/siemens/mc_tcu3/ptn3460.h 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/31761/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h index 6ae3e2f..3ff35d9 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h @@ -34,7 +34,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config { - /* DiplayPort interface control. */ + /* DisplayPort interface control. */ uint8_t dp_interface_ctrl; /* LVDS interface control register 1. */ uint8_t lvds_interface_ctrl1; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h index bdcbf0e..2a52bf5 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h @@ -34,7 +34,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config { - /* DiplayPort interface control. */ + /* DisplayPort interface control. */ uint8_t dp_interface_ctrl; /* LVDS interface control register 1. */ uint8_t lvds_interface_ctrl1; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h index 6ae3e2f..3ff35d9 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h @@ -34,7 +34,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config { - /* DiplayPort interface control. */ + /* DisplayPort interface control. */ uint8_t dp_interface_ctrl; /* LVDS interface control register 1. */ uint8_t lvds_interface_ctrl1; diff --git a/src/mainboard/siemens/mc_tcu3/ptn3460.h b/src/mainboard/siemens/mc_tcu3/ptn3460.h index 97bcb41..217c68a 100644 --- a/src/mainboard/siemens/mc_tcu3/ptn3460.h +++ b/src/mainboard/siemens/mc_tcu3/ptn3460.h @@ -36,7 +36,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config{ - u8 dp_interface_ctrl; /* DiplayPort interface control */ + u8 dp_interface_ctrl; /* DisplayPort interface control */ u8 lvds_interface_ctrl1; /* LVDS interface control register 1 */ u8 lvds_interface_ctrl2; /* LVDS interface control register 2 */ u8 lvds_interface_ctrl3; /* LVDS interface control register 3 */
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31761 )
Change subject: mb/siemens/{mc_apl1,mc_tcu3}: Fix typo on "Display" ......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing it.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31761 )
Change subject: mb/siemens/{mc_apl1,mc_tcu3}: Fix typo on "Display" ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31761 )
Change subject: mb/siemens/{mc_apl1,mc_tcu3}: Fix typo on "Display" ......................................................................
mb/siemens/{mc_apl1,mc_tcu3}: Fix typo on "Display"
Change-Id: I58ecd95a8427eba87611dd8ea4616aedbb1d01c9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31761 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h M src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h M src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h M src/mainboard/siemens/mc_tcu3/ptn3460.h 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h index 6ae3e2f..3ff35d9 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/include/variant/ptn3460.h @@ -34,7 +34,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config { - /* DiplayPort interface control. */ + /* DisplayPort interface control. */ uint8_t dp_interface_ctrl; /* LVDS interface control register 1. */ uint8_t lvds_interface_ctrl1; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h index bdcbf0e..2a52bf5 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h @@ -34,7 +34,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config { - /* DiplayPort interface control. */ + /* DisplayPort interface control. */ uint8_t dp_interface_ctrl; /* LVDS interface control register 1. */ uint8_t lvds_interface_ctrl1; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h index 6ae3e2f..3ff35d9 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/include/variant/ptn3460.h @@ -34,7 +34,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config { - /* DiplayPort interface control. */ + /* DisplayPort interface control. */ uint8_t dp_interface_ctrl; /* LVDS interface control register 1. */ uint8_t lvds_interface_ctrl1; diff --git a/src/mainboard/siemens/mc_tcu3/ptn3460.h b/src/mainboard/siemens/mc_tcu3/ptn3460.h index 97bcb41..217c68a 100644 --- a/src/mainboard/siemens/mc_tcu3/ptn3460.h +++ b/src/mainboard/siemens/mc_tcu3/ptn3460.h @@ -36,7 +36,7 @@ #define PTN_INVALID_EDID 0x20000000
struct ptn_3460_config{ - u8 dp_interface_ctrl; /* DiplayPort interface control */ + u8 dp_interface_ctrl; /* DisplayPort interface control */ u8 lvds_interface_ctrl1; /* LVDS interface control register 1 */ u8 lvds_interface_ctrl2; /* LVDS interface control register 2 */ u8 lvds_interface_ctrl3; /* LVDS interface control register 3 */
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)