Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58767 )
Change subject: driver/intel/mipi_camera: Add support for _DSC field
......................................................................
Patch Set 6:
(3 comments)
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/58767/comment/41d7986e_c4c171c3
PS6, Line 850: (
nit: space after `if`
https://review.coreboot.org/c/coreboot/+/58767/comment/47c5c56e_d4b65e79
PS6, Line 852: 0x4
`ACPI_DEVICE_SLEEP_D3_COLD`
but should this value be configurable in chip.h?
File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/58767/comment/9ed6275b_6b015bf5
PS5, Line 260: acpi_dsc;
will test by adding _DSC in all camera devices
If the kernel doesn't check for its existence, I don't see how it could be a problem to include it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5471f144918413a2982f86beaf3dbf7e4e66cc9b
Gerrit-Change-Number: 58767
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Nov 2021 14:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment