Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86276?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/intel/gma: Don't advertise support for opregion mailbox #2 ......................................................................
drivers/intel/gma: Don't advertise support for opregion mailbox #2
IGD mailbox #2, Software SCI Interface, is not supported by coreboot currently, as it requires supporting the Get BIOS Data (GBDA) and System BIOS Callbacks (SBCB) interfaces. Since coreboot doesn't support these, don't advertise mailbox #2 support.
This eliminates an error with the Linux display drivers: "SWSCI request timed out"
TEST=build/boot Linux 6.9, Win11 on starlabs/starlite_adl
Change-Id: I8efcf9c5d384b6e0ce159d65cb1497c2e2e47f42 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86276 Reviewed-by: Sean Rhodes sean@starlabs.systems Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/drivers/intel/gma/opregion.h 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Sean Rhodes: Looks good to me, approved build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, but someone else must approve
diff --git a/src/drivers/intel/gma/opregion.h b/src/drivers/intel/gma/opregion.h index 7b6a85d..2de9213 100644 --- a/src/drivers/intel/gma/opregion.h +++ b/src/drivers/intel/gma/opregion.h @@ -41,8 +41,7 @@ #define IGD_MBOX4 (1 << 3) #define IGD_MBOX5 (1 << 4)
-#define MAILBOXES_MOBILE (IGD_MBOX1 | IGD_MBOX2 | IGD_MBOX3 | \ - IGD_MBOX4 | IGD_MBOX5) +#define MAILBOXES_MOBILE (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5) #define MAILBOXES_DESKTOP (IGD_MBOX2 | IGD_MBOX4)
#define SBIOS_VERSION_SIZE 32