Change in coreboot[master]: nb/amd/amdfam10/bootblock.c: Use generic PCI find capability functions
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62095 )
Change subject: nb/amd/amdfam10/bootblock.c: Use generic PCI find capability functions ......................................................................
Patch Set 1:
(17 comments)
File src/northbridge/amd/amdfam10/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/6d1a141e_f7f28de7 PS1, Line 82: pos = pci_s_find_capability(PCI_DEV(0,0,0), PCI_CAP_ID_HT); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/90cdb628_0323d86c PS1, Line 82: pos = pci_s_find_capability(PCI_DEV(0,0,0), PCI_CAP_ID_HT); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/5307c239_be7348c3 PS1, Line 90: flags = pci_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/d7b5b049_c8bba27e PS1, Line 90: flags = pci_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/585f6eb3_aba39b3f PS1, Line 91: pci_write_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS, flags); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/1b31925d_79ef46df PS1, Line 91: pci_write_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS, flags); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/c52ff66a_a0dd1710 PS1, Line 92: flags = pci_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/d4ff58c1_ae02f84d PS1, Line 92: flags = pci_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/ca3b415d_9677c559 PS1, Line 100: if (!end_used) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/201e6b61_9b7aa533 PS1, Line 101: next_unitid = CONFIG_HT_CHAIN_END_UNITID_BASE; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/8012bdea_a8ebc693 PS1, Line 103: } else { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/59688bd2_7c3b8728 PS1, Line 123: pci_write_config16(PCI_DEV(0, 0, 0), pos + PCI_CAP_FLAGS, flags); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/2600e3fb_df394a88 PS1, Line 126: ctrl_off = ((flags >> 10) & 1)? spaces required around that '?' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/d9fd8d5c_13622c41 PS1, Line 132: if (ctrl & (1 << 6)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/fe17d1f6_af3a5c48 PS1, Line 144: ctrl |= ((1 << 4) | (1 <<8)); // Link fail + Crc need consistent spacing around '<<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/5114ef97_c1d45e26 PS1, Line 156: pos = pci_s_find_next_capability(PCI_DEV(0,0,0), PCI_CAP_ID_HT, 0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141272): https://review.coreboot.org/c/coreboot/+/62095/comment/ff75bee2_a104f5a0 PS1, Line 156: pos = pci_s_find_next_capability(PCI_DEV(0,0,0), PCI_CAP_ID_HT, 0); space required after that ',' (ctx:VxV)
-
build bot (Jenkins) (Code Review)