Change in coreboot[master]: mb/google/guybrush: Configure EN_SPKR GPIO in PSP verstage - coreboot-gerrit

1 Dec 2021


      Attention is currently required from: Jon Murphy, Rob Barnes, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59813 )
Change subject: mb/google/guybrush: Configure EN_SPKR GPIO in PSP verstage
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59813/comment/2849d4f3_6897a261 
PS1, Line 13: mechanical off(G3)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/59813/comment/6878a89f_54765422 
PS1, Line 17: EN_SPKR GPIO(in S5 domain)
Please add a space before the (.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59813
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a52a167da9c7040731da5d355ec345fd9b13762
Gerrit-Change-Number: 59813
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 21:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment