Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35472 )
Change subject: drivers/i2c/at24rf08c: Add proper Kconfig option ......................................................................
drivers/i2c/at24rf08c: Add proper Kconfig option
The existing Kconfig code made SMBIOS_PROVIDED_BY_MOBO depend on VENDOR_LENOVO. Thus, it couldn't be selected by boards from other vendors. So we add another Kconfig that selects it here.
NB. It's still unclear how the two drivers in this directory are related (at24rf08c and lenovo_serial). From the code, it doesn't look like the latter belongs here.
Change-Id: Iaa5c5a584f2a5e2426352ec6aa681f99a55efa49 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/drivers/i2c/at24rf08c/Kconfig M src/drivers/i2c/at24rf08c/Makefile.inc 2 files changed, 5 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/35472/1
diff --git a/src/drivers/i2c/at24rf08c/Kconfig b/src/drivers/i2c/at24rf08c/Kconfig index e8ee986..8a5eb20 100644 --- a/src/drivers/i2c/at24rf08c/Kconfig +++ b/src/drivers/i2c/at24rf08c/Kconfig @@ -1,7 +1,4 @@ -if VENDOR_LENOVO - -config SMBIOS_PROVIDED_BY_MOBO +config DRIVER_LENOVO_SERIALS bool - default y - -endif + default y if VENDOR_LENOVO + select SMBIOS_PROVIDED_BY_MOBO diff --git a/src/drivers/i2c/at24rf08c/Makefile.inc b/src/drivers/i2c/at24rf08c/Makefile.inc index 10c91d1..985aa68 100644 --- a/src/drivers/i2c/at24rf08c/Makefile.inc +++ b/src/drivers/i2c/at24rf08c/Makefile.inc @@ -1,2 +1,2 @@ -ramstage-$(CONFIG_VENDOR_LENOVO) += at24rf08c.c -ramstage-$(CONFIG_VENDOR_LENOVO) += lenovo_serials.c +ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += at24rf08c.c +ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += lenovo_serials.c
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35472 )
Change subject: drivers/i2c/at24rf08c: Add proper Kconfig option ......................................................................
Patch Set 1: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35472 )
Change subject: drivers/i2c/at24rf08c: Add proper Kconfig option ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35472 )
Change subject: drivers/i2c/at24rf08c: Add proper Kconfig option ......................................................................
drivers/i2c/at24rf08c: Add proper Kconfig option
The existing Kconfig code made SMBIOS_PROVIDED_BY_MOBO depend on VENDOR_LENOVO. Thus, it couldn't be selected by boards from other vendors. So we add another Kconfig that selects it here.
NB. It's still unclear how the two drivers in this directory are related (at24rf08c and lenovo_serial). From the code, it doesn't look like the latter belongs here.
Change-Id: Iaa5c5a584f2a5e2426352ec6aa681f99a55efa49 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35472 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/i2c/at24rf08c/Kconfig M src/drivers/i2c/at24rf08c/Makefile.inc 2 files changed, 5 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/drivers/i2c/at24rf08c/Kconfig b/src/drivers/i2c/at24rf08c/Kconfig index e8ee986..8a5eb20 100644 --- a/src/drivers/i2c/at24rf08c/Kconfig +++ b/src/drivers/i2c/at24rf08c/Kconfig @@ -1,7 +1,4 @@ -if VENDOR_LENOVO - -config SMBIOS_PROVIDED_BY_MOBO +config DRIVER_LENOVO_SERIALS bool - default y - -endif + default y if VENDOR_LENOVO + select SMBIOS_PROVIDED_BY_MOBO diff --git a/src/drivers/i2c/at24rf08c/Makefile.inc b/src/drivers/i2c/at24rf08c/Makefile.inc index 10c91d1..985aa68 100644 --- a/src/drivers/i2c/at24rf08c/Makefile.inc +++ b/src/drivers/i2c/at24rf08c/Makefile.inc @@ -1,2 +1,2 @@ -ramstage-$(CONFIG_VENDOR_LENOVO) += at24rf08c.c -ramstage-$(CONFIG_VENDOR_LENOVO) += lenovo_serials.c +ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += at24rf08c.c +ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += lenovo_serials.c
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)