Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68940 )
(
6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/skyrim: Disable SD ASPM ......................................................................
mb/google/skyrim: Disable SD ASPM
Disable ASPM on SD until b/245550573 is root-caused/fixed. Logical_lane 1 on winterhold is EMMC device. Disable ASPM for suspend issue.
BUG=b:249914847, b:245550573 TEST=emerge-skyrim coreboot chromeos-bootimage and test on whiterun proto emmc sku with suspend_stress_test -c 10
Change-Id: If080cdb517a3f22aa89c8053fb6bba9e931c6f76 Signed-off-by: EricKY Cheng ericky_cheng@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/68940 Reviewed-by: Fred Reitberger reitbergerfred@gmail.com Reviewed-by: Tim Van Patten timvp@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/skyrim/port_descriptors.c 1 file changed, 25 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Fred Reitberger: Looks good to me, approved Tim Van Patten: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index 91316b3..c7b1a8b 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -28,7 +28,7 @@ .function_number = PCI_FUNC(SD_DEVFN), .link_speed_capability = GEN3, .turn_off_unused_lanes = true, - .link_aspm = ASPM_L1, + .link_aspm = ASPM_DISABLED, // TODO: switch to ASPM_L1 after b:245550573 .link_hotplug = 3, .gpio_group_id = GPIO_27, .clk_req = CLK_REQ1,