Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Nicholas Chin, Patrick Rudolph.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86772?usp=email )
Change subject: doc/arch/x86: Add MP-Init documentation
......................................................................
Patch Set 5:
(5 comments)
File Documentation/arch/x86/mp_init.md:
https://review.coreboot.org/c/coreboot/+/86772/comment/97380336_5711ef9b?usp... :
PS5, Line 31: init_bsp()
Enclose function name in backticks so that it renders as an inline code block […]
Done
https://review.coreboot.org/c/coreboot/+/86772/comment/c7a04be8_b6a84189?usp... :
PS5, Line 36: ap_init()
Same here […]
Done
https://review.coreboot.org/c/coreboot/+/86772/comment/640415bf_0a8c8389?usp... :
PS5, Line 56: setting
Capitalize […]
Done
https://review.coreboot.org/c/coreboot/+/86772/comment/17400af9_34468ae1?usp... :
PS5, Line 58: implemented in SMM.
: Now
Markdown requires a blank line in between paragraphs, otherwise it renders as the same paragraph.
Done
https://review.coreboot.org/c/coreboot/+/86772/comment/ed2cc697_dc83e792?usp... :
PS5, Line 59: jumps.
: Unf
Same here, add a blank line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86772?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1d16d608981d83438999321b30c2921a526f307e
Gerrit-Change-Number: 86772
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 13 Apr 2025 19:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com