Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Leon Groß, Patrick Rudolph, Paul Menzel.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email )
Change subject: mb/emulation: Add SIMICS QSP support
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/emulation/simics-qsp/memmap.c:
https://review.coreboot.org/c/coreboot/+/77905/comment/bb5303c5_de071cea :
PS4, Line 97: postcar_frame_add_mtrr(pcf, top_of_ram - 8*MiB, 8*MiB, MTRR_TYPE_WRBACK);
: postcar_frame_add_mtrr(pcf, top_of_ram, 8*MiB, MTRR_TYPE_WRBACK);
The simulator itself implements MTRR capabilities, why wouldn't we set them up properly? I think thi […]
Simulator is different with emulator. Simics actually simulates the RTL design.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77905?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I175b20bb4746608e4d868aa96492fc06c149bd36
Gerrit-Change-Number: 77905
Gerrit-PatchSet: 11
Gerrit-Owner: Leon Groß
leon.gross@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Leon Groß
leon.gross@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 31 Oct 2023 13:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Leon Groß
leon.gross@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment